Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteor update all packages #957

Merged
merged 1 commit into from
Apr 4, 2017
Merged

meteor update all packages #957

merged 1 commit into from
Apr 4, 2017

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Mar 30, 2017

Related issue #788

Upgrade Meteor to 1.4.x branch

Upgrade Atmosphere packages


This change is Reviewable

@brylie brylie mentioned this pull request Mar 30, 2017
@xet7
Copy link
Member

xet7 commented Mar 30, 2017

@brylie

What commands you used to build this with meteor 1.4 ?

@stephenmoloney
Copy link
Contributor

I'm taking a look at this now too...

@brylie
Copy link
Contributor Author

brylie commented Mar 30, 2017

Thanks for the quick review.

I just run meteor to start the app. What is the normal 'build' process?

@stephenmoloney
Copy link
Contributor

stephenmoloney commented Mar 30, 2017

I'd recommend that for testing the build works, to try

echo 'NODE_VERSION=v7.8.0' >> .env && echo 'METEOR_RELEASE=1.4.3.2' >> .env && echo 'NPM_VERSION=4.4.4' >> .env && echo 'ARCHITECTURE=linux-x64' >> .env && echo 'SRC_PATH=./' >> .env && sudo docker-compose up -d --build --force-recreate

@stephenmoloney
Copy link
Contributor

We'll have to bump meteor 1.4.3.2 --> to 1.4.4 soon too

@stephenmoloney
Copy link
Contributor

stephenmoloney commented Mar 30, 2017

Right now I'm getting an error

Failed at the [email protected] install script '(node-gyp rebuild 2> builderror.log) || (exit 0)'. npm  \
ERR! Make sure you have the latest version of node.js and npm installed
If you do, this is most likely a problem with the bson package,
npm ERR! not with npm itself.

npm is latest. nodejs is latest --- so some issue with bson there.

@rhelsing
Copy link
Contributor

@brylie would you mind updating the meteor version in the Dockerfile as well? @stephenmoloney does anything else need to be changed in the dockerfile?

@stephenmoloney
Copy link
Contributor

@rhelsing
I think it's better not to update the Dockerfile until the build is proven to work on a specific meteor version. I suspect that meteor version 1.4.3.2 is going to be a broken build and is it at the moment.

All this does is add more issues to the Dockerfile making it harder to ascertain the issue.

The ARG variables are deliberately added to the Dockerfile to easily override.

example:

echo 'NODE_VERSION=v7.8.0' >> .env && \ 
echo 'METEOR_RELEASE=1.4.3.2' >> .env && \
echo 'NPM_VERSION=4.4.4' >> .env && \
echo 'ARCHITECTURE=linux-x64' >> .env && \
echo 'SRC_PATH=./' >> .env && \
sudo docker-compose up -d --build --force-recreate

Let's change the Dockerfile in the public canonical repo only once we have a proven working build.

@stephenmoloney
Copy link
Contributor

@rhelsing @brylie
Do you know much about package management - i don't use meteor.

How can I stop npm doing an upgrade of a package automatically?
for example in packages i set npm-mongo to 1.4.45 .
But it keeps getting upgraded automatically by npm.

Changes to your project's package version selections:
npm-mongo* upgraded from 1.4.45 to 2.2.24

I never asked for the upgrade though - any ideas how to block the upgrade?

@brylie
Copy link
Contributor Author

brylie commented Mar 30, 2017

@stephenmoloney, you can pin an NPM package to a specific version. Something like

npm install package@version --save

@stephenmoloney
Copy link
Contributor

I'm trying to downgrade npm-mongo to an older version but I can't that is specified in the .meteor/versions file. Seems it forces the upgrade and gives some reason.
@xet7
Due to using an old version of mongodb, we cannot upgrade mongo version?
Or can we upgrade the mongodb being used?

@brylie
Copy link
Contributor Author

brylie commented Mar 31, 2017

can we upgrade the mongodb being used?

You can upgrade the running MongoDB instance. These instructions might be helpful.

@stephenmoloney
Copy link
Contributor

@brylie I think some issues arose that were more than meets the eye, @xet7 knows more about.
This is why mongodb is fixed in the dockerfile.

@xet7
Copy link
Member

xet7 commented Mar 31, 2017

@stephenmoloney

Backup your MongoDB 3.2.x and try upgrading to newer version:
https://github.com/wekan/wekan/wiki/Export-Docker-Mongo-Data

I presume newer Meteor 1.4 supports newest MongoDB 3.4.x.

But after upgrade, if uploading images to Wekan crashes Wekan, you need to to go back to newest MongoDB 3.2.x.

I have not had time to try Meteor 1.4. stuff yet.

@stephenmoloney
Copy link
Contributor

stephenmoloney commented Apr 4, 2017

I may have fixed the dockerbuild -- need to check a few things first

I think you can merge this pull request. I'll make another one later.

@xet7 xet7 merged commit 656e7e6 into wekan:devel Apr 4, 2017
@HLFH
Copy link

HLFH commented Apr 4, 2017

@xet7 Hi. What will be the recommended Node.js version now?

@xet7
Copy link
Member

xet7 commented Apr 4, 2017

@HLFH

Newest 4.x I think.

@xet7
Copy link
Member

xet7 commented Apr 5, 2017

I have moved devel back to Meteor 1.3.

Meteor 1.4 work continues in meteor-1.4 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants