Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove highlight from course ID #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

weiquu
Copy link
Owner

@weiquu weiquu commented Dec 17, 2022

Experimental tweak to get familiar with teammates and how it is being structured.

PR Checklist

Ensure that you have:

  • Read and understood our PR guideline: https://teammates.github.io/teammates/process.html#step-4-submit-a-pr
    • Added the issue number to the "Fixes" keyword above
    • Titled the PR as specified in the abovementioned document
  • Made your changes on a branch other than master and release
  • Gone through all the changes in this PR and ensured that:
    • They addressed one (and only one) issue
    • No unintended changes were made
  • Run and passed static analysis: ./gradlew lint and npm run lint
  • Added/updated tests, if changes in functionality were involved
  • Added/updated documentation to public APIs (classes, methods, variables), if applicable

Outline of Problem
Previously, the instructor's Search Students page would highlight the course ID if the search term appeared there. A quick search through issues regarding "highlight" does not yield much about this particular behaviour. However, I believe that this is unintended as the search is meant to search for students only, hence only data from students should be highlighted. In addition, simply searching for the course ID (without any matches for students) gives no results, implying that the course ID shouldn't be "gone through" by the search term.

Outline of Solution
Removed the portion of code causing the course ID to be highlighted. See below for a comparison between before and after:
before
after

@weiquu weiquu changed the title Remove highlight from course name Remove highlight from course ID Dec 17, 2022
weiquu pushed a commit that referenced this pull request Feb 4, 2023
Backend - Entity, DB, Attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant