-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to last Vue CLI v4 template #312
Merged
Merged
Changes from 50 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
d6ba287
Fixed a typo
sronveaux f3f0bb2
Added a few lines to stick with the source template
sronveaux 4619cf9
Changed eslint-html-plugin to eslint-vue-plugin
sronveaux ee7aff8
Changed import style to conform to source template
sronveaux 51a0b49
Changed import style and var usage to conform to source templates
sronveaux 01b99e8
Changed import style, var usage and arrow functions to conform to sou…
sronveaux e82af80
Removed some packages and added others to stay in tune with source te…
sronveaux 5edb0c4
Added the first version of the new webpack config files
sronveaux b6ab124
Corrected a bug linked to babel-eslint-parser
sronveaux b75d91a
Added the possibility to open the browser specified in the config/ind…
sronveaux 909b7eb
Removed opn which is installed as peer dependency now
sronveaux 66a889b
Corrected a bug linked to serving static files while in development mode
sronveaux 1b28a45
Removed the now useless build scripts
sronveaux c11e37b
Added a useless <div> tag so that vue-eslint stops complaining about it
sronveaux 77b0b75
Fixed a lot of lint errors now that vue-eslint works as expected
sronveaux abbf7cc
Resetted the package-lock.json to avoid a small incompatibility with …
sronveaux ee51e31
Upgraded the first files to the new vue-CLI V3 format
sronveaux 91c3174
Made changes to conform to new linting configuration format
sronveaux a9cdcd2
Corrected an indentation error returned by ESLint
sronveaux 40b7ce7
Converted the Babel and postCSS config files to the new format
sronveaux 012547d
Moved the index.html and embedded.html files to the public directory.…
sronveaux cb96ffe
Added a first version of the vue.config.js file
sronveaux d5e6ade
Changed the dev and build script to conform to the Vue-CLI V3 format
sronveaux cf19d16
Added two Babel polyfills needed as the project was reverted to core-…
sronveaux 1bed884
Added eslint-formatter-friendly again to avoid a warning reporting bu…
sronveaux a468846
Changed the main.js to conform to new Vue-CLI template and to Vue bes…
sronveaux e7762ef
Changed the vue.config.js to have the favicon working again
sronveaux ff0c8c1
Commented an ESLint rule as wegue main script uses console logs to re…
sronveaux a141396
Changed README.md to reflect the new npm commands syntax
sronveaux 611764b
Renamed test directory to tests as in the new Vue-CLI template
sronveaux 491a787
Added updated Karma back in the project
sronveaux 028e20c
Changed the path to the Webpack config file in karma.conf.js
sronveaux 5a8caaf
Removed the now useless build and config directories
sronveaux 76e21db
Added the source map configuration to reflect what was done before
sronveaux ede4680
Added cross-env back and added the npm script to run tests through Karma
sronveaux 3e439b7
Added babel-plugin-istanbul and changed the babel.config.js to make c…
sronveaux 2183fea
Changed a test and made it async to avoid a new strange bug(https://g…
sronveaux a5a09e7
Changed a forgotten file to use correct test files
sronveaux 4fefd3b
changed an npm script to point to correct test directory
sronveaux 0b9480c
Changed two commands in the documentation
sronveaux a80ed56
Merged official master branch before amending this branch following d…
sronveaux e8f1475
Added unit tests coverage reporrts to .gitignore and .dockerignore files
sronveaux b78606d
Made Karma the default test runner and removed the Vue CLI mocha-webp…
sronveaux edf6427
Changed the command used to run development server inside the Worksho…
sronveaux dad49c4
Reintroduced the min engine requirements to conform to Vue-CLI V3 rec…
sronveaux 4480fe3
Set APP resolver alias to base configuration instead of test configur…
sronveaux 4a3b2a2
Added mocha environment in the .eslintrc.js file
sronveaux 147f29a
Merged official master branch before upgrading to VueCLI4
sronveaux 8353669
Upgraded all vueCLI and plugins to latest V4
sronveaux aa02309
Changed .browserlistrc .gitignore and .eslinrc.js to conform to new V…
sronveaux 8007461
Removed two config files which are not needed anymore with new Vue te…
sronveaux 1a2e46b
Changed a font name to conform to new Vue template
sronveaux ed54a82
Added .eslintrc in tests/unit to avoid spurrious errors of undeclared…
sronveaux b3794ff
Fixed a lot of linter errors linked to the new rules of eslint6
sronveaux f44207b
Changed how hasOwnProperty is used to conform to a new eslint rule
sronveaux 5d1cb1b
Fixed some linter errors in app-starter linked to the new rules of es…
sronveaux d6448a7
Removed two Babel polyfills which are now included in core-js@3
sronveaux 05a6455
Changed some unit tests to call setProps correctly (https://test-util…
sronveaux 98ccffd
Added the openssl-legacy-provider flag to get around digital envelope…
sronveaux 3df6254
Corrected the coverage of .vue file bug
sronveaux 16cc072
Merged official master branch to resolve conflicts
sronveaux 5397902
Raise lint errors when using debugger in production
sronveaux 5e66257
Removed a trailing space which gave errors when building under Docker
sronveaux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
> 1% | ||
last 2 versions | ||
not dead |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
app/ | ||
dist/ | ||
node_modules/ | ||
test/unit/coverage/ | ||
tests/unit/coverage/ | ||
.git/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
root = true | ||
|
||
[*] | ||
charset = utf-8 | ||
[*.{js,jsx,ts,tsx,vue}] | ||
indent_style = space | ||
indent_size = 2 | ||
end_of_line = lf | ||
insert_final_newline = true | ||
trim_trailing_whitespace = true | ||
insert_final_newline = true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
build/*.js | ||
config/*.js | ||
/build/ | ||
/config/ | ||
/test/unit/coverage/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,27 @@ | ||
.DS_Store | ||
node_modules/ | ||
dist/ | ||
node_modules | ||
/dist | ||
|
||
|
||
# local env files | ||
.env.local | ||
.env.*.local | ||
|
||
# Log files | ||
npm-debug.log* | ||
yarn-debug.log* | ||
yarn-error.log* | ||
test/unit/coverage | ||
pnpm-debug.log* | ||
|
||
# Unit tests coverage reports | ||
test/unit/coverage/ | ||
tests/unit/coverage/ | ||
|
||
# Editor directories and files | ||
.idea | ||
.vscode | ||
*.suo | ||
*.ntvs* | ||
*.njsproj | ||
*.sln | ||
*.sln | ||
*.sw? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
module.exports = { | ||
presets: [ | ||
'@vue/cli-plugin-babel/preset' | ||
], | ||
plugins: [ | ||
'@babel/plugin-proposal-nullish-coalescing-operator', | ||
'@babel/plugin-proposal-optional-chaining' | ||
], | ||
'env': { | ||
'test': { | ||
'plugins': ['istanbul'] | ||
} | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would prefer to raise a 'no-debugger' error for production environments.
And as a future proposal - probably as part of a seperate PR:
Maybe we could do something about the 'no-console' setting. E.g. we could pool all wegue logging operations into a logger module and then use the
eslint-disable
directive there. So warnings could be generally enabled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem to revert the change, simply, that's not something that I personally changed, this is what is present in
Vue-CLI V4
andVue-CLI V5
templates.Your future proposal is intersting, it would be nice to enable this rule in the end for sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted to raise error if
debugger
is used while building for production