Merge pull request #303 from henrykironde/sting-NA

Set default as NA in phenocam function
weecology · Aug 8, 2024 · 7e15d88 · 7e15d88
2 parents 560de90 + 2006916
commit 7e15d88
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -75,5 +75,5 @@ Suggests:
 VignetteBuilder: 
     knitr
 Encoding: UTF-8
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 Config/testthat/edition: 3
diff --git a/R/phenocam.R b/R/phenocam.R
@@ -24,7 +24,7 @@ phenocam <- function(level = "daily", path = get_default_data_path())
 
 
   pheno <- read.csv(url,
-                    skip = 22, header = TRUE, na.strings = c(""), stringsAsFactors = FALSE,
+                    skip = 22, header = TRUE, na.strings = c("", "NA"), stringsAsFactors = FALSE,
                     colClasses = c("Date", rep("integer", 3), "character",
                                    rep("numeric", 22), rep("character", 5))) %>%
     dplyr::arrange(.data$date)

diff --git a/man/load_datafile.Rd b/man/load_datafile.Rd
diff --git a/tests/testthat/test-99-regression.R b/tests/testthat/test-99-regression.R
@@ -321,9 +321,9 @@ test_that("data generated by default setting is same (phenocam)", {
   attributes(data) <- attributes(data)[sort(names(attributes(data)))]
 
   # correct for NAs in output
-  expect_known_hash(is.na(data), "4c798df02b")
+  expect_known_hash(is.na(data), "888e883896")
   data[is.na(data)] <- -999999
-  expect_known_hash(data, "040fa9c6b1")
+  expect_known_hash(data, "7b8d62a5a9")
 })
 
 test_that("seasonal summaries generated by default setting is same", {