Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pycall api updates #29

Closed
stevengj opened this issue Feb 28, 2019 · 4 comments
Closed

pycall api updates #29

stevengj opened this issue Feb 28, 2019 · 4 comments

Comments

@stevengj
Copy link

PyCall 1.90.0 is now released, which change o[:foo] and o["foo"] to o.foo and o."foo", respectively, for python objects o; see also JuliaPy/PyCall.jl#629.

The old getindex methods still work but are deprecated, so you'll want to put out a new release that uses the new methods and REQUIREs PyCall 1.90.0 to avoid having zillions of deprecation messages.

@henrykironde
Copy link
Contributor

@stevengj a big thank you from the team at the Retriever.ji. This is such a good practice. Is this automated?

@stevengj
Copy link
Author

stevengj commented Mar 1, 2019

No, I just searched the metadata for packages that require PyCall and manually filed issues with packages that seemed active. It would be nice to have a way to automate this.

@ethanwhite
Copy link
Member

@henrykironde I did some quick searching of the current master branch and couldn't find current usage of either the [:foo] notation or getindex. If that seems right to you we can close this. If I've missed something (very possible as I'm just digging in) just point me in the right direction and I'll get these updated.

@henrykironde
Copy link
Contributor

We do not have this. Thanks for the reminder. I kept this opened to make sure pycall works fine before the release. Thanks @stevengj for this update, saved us some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants