[WIP] Distribute config file from primary location #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had two copies of deepforest_config.yml. The first was the main copy in the root directory of the repo. The second was a copy that got distributed with the package. This is error prone and unnecessary since we can package directly from the root file. Closes weecology#531
ethanwhite
force-pushed
the
one-config-to-rule-them-all
branch
from
fbf2f66
to
21276f6
Compare
ethanwhite
changed the title
|
This is currently broken because we're not actually testing against the installed package, we're testing against the source code, which doesn't have the data included. This is part of the same problem as #562. I'm going to open an issue to discuss the general solution |
|
This relates to a broader conversation that I would love to move to hydra, add argparse support for config. This is a 2.0 kinda thing, there may be a more short term patch here for the immediate need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two copies of deepforest_config.yml. The first was the main copy in the root directory of the repo. The second was a copy that got distributed with the package. This is error prone and unnecessary since we can package directly from the root file.
Unless I'm misunderstanding #531 I think this should address it.