Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS updateAllowedElementScript src works with element #23

Open
the-ge opened this issue Aug 20, 2022 · 0 comments
Open

JS updateAllowedElementScript src works with element #23

the-ge opened this issue Aug 20, 2022 · 0 comments

Comments

@the-ge
Copy link
Contributor

the-ge commented Aug 20, 2022

I had to change

        if (dataset.src) {
            newEl.src = dataset.src
        }

to

        if (el.src) {
            newEl.src = el.src
        }

in src/js/PrivacyWire.js:403-404, (updateAllowedElementScript(el)) to get allowing scripts only after consent to work.

I know just enough JavaScript to be dangerous, so I'm a bit unsure about this being a bug or a side effect of the tortures I inflicted on ProcessWire and PrivacyWire 😊
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@the-ge