Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use xdg-open to play files on linux. #1533

Closed
bilelmoussaoui opened this issue Jan 5, 2019 · 5 comments
Closed

Use xdg-open to play files on linux. #1533

bilelmoussaoui opened this issue Jan 5, 2019 · 5 comments
Labels

Comments

@bilelmoussaoui
Copy link
Contributor

What version of WebTorrent Desktop? Version 0.20.0 (0.99.3) (64-bit)

What operating system and version? Fedora Rawhide

What did you do? Run a random video that's not supported by WebTorrent Desktop (audio or video file)

What did you expect to happen? The app to run it in my external music/video player

What actually happened? Nothing, it suggests me to install either VLC or MPV while I don't want any of them. I have to set the binary path of the app manually which sucks.

You can just use xdg-open $filepath and that will open the assigned app to open that file automatically. It would be nice to fallback to this instead.

@stale
Copy link

stale bot commented Apr 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 5, 2019
@stale stale bot closed this as completed Apr 13, 2019
@bilelmoussaoui
Copy link
Contributor Author

Can we reopen this one?

@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
@webtorrent webtorrent unlocked this conversation Aug 24, 2019
@feross
Copy link
Member

feross commented Aug 24, 2019

@bilelmoussaoui The issue is that we don't actually have the full file downloaded onto the disk. So, we're not opening the video player with e.g. a .mp4 file path but rather an http:// url. Won't this cause your default web browser to open? I don't think that's what you actually want.

@bilelmoussaoui
Copy link
Contributor Author

@feross Thanks for the reply. Totally missed this. Sorry for the noise!

@Eskander
Copy link

The issue is that we don't actually have the full file downloaded onto the disk. So, we're not opening the video player with e.g. a .mp4 file path but rather an http:// url.

Since the videos are downloaded sequentially, it is actually possible to use xdg-open file-name.mkv while the video is being downloaded. I tested that with both VLC and MPV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants