Tests failing under Node v0.10.9

[hudgins]

Related discussion here: nodejs/node-v0.x-archive#5557

NODE_TLS_REJECT_UNAUTHORIZED=0 && npm test

> [email protected] test /Users/ahudgins/bug/node_modules/ws
> make test


  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․․
  ․․․․․․

  ✖ 11 of 162 tests failed:

  1) WebSocket properties #bytesReceived exposes number of bytes received:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runnable.js:167:14)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  2) WebSocket events emits a ping event:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runnable.js:167:14)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  3) WebSocket events emits a pong event:
     Error: timeout of 2000ms exceeded
      at null.<anonymous> (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runnable.js:167:14)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)

  4) WebSocket W3C API emulation should receive vaild CloseEvent when server closes with code 1001:
     AssertionError: false == true
      at WebSocket.<anonymous> (/Users/ahudgins/bug/node_modules/ws/test/WebSocket.test.js:1312:18)
      at WebSocket.onClose (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:329:18)
      at WebSocket.EventEmitter.emit (events.js:98:17)
      at WebSocket.cleanupWebsocketResources (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:649:23)
      at Socket.EventEmitter.emit (events.js:117:20)
      at _stream_readable.js:910:16
      at process._tickCallback (node.js:415:13)

  5) WebSocket ssl can connect to secure websocket server:
     TypeError: Uncaught, unspecified "error" event.
      at TypeError (<anonymous>)
      at WebSocket.EventEmitter.emit (events.js:74:15)
      at Receiver.self._receiver.onerror (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:566:10)
      at Receiver.error (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:301:8)
      at Receiver.processPacket (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:187:10)
      at Receiver.add (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:93:24)
      at CleartextStream.firstHandler (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:524:22)
      at CleartextStream.EventEmitter.emit (events.js:95:17)
      at CleartextStream.<anonymous> (_stream_readable.js:736:14)
      at CleartextStream.EventEmitter.emit (events.js:92:17)
      at emitReadable_ (_stream_readable.js:408:10)
      at emitReadable (_stream_readable.js:404:5)
      at readableAddChunk (_stream_readable.js:165:9)
      at CleartextStream.Readable.push (_stream_readable.js:127:10)
      at CleartextStream.read [as _read] (tls.js:510:10)
      at CleartextStream.Readable.read (_stream_readable.js:320:10)
      at EncryptedStream.write [as _write] (tls.js:366:25)
      at doWrite (_stream_writable.js:219:10)
      at writeOrBuffer (_stream_writable.js:209:5)
      at EncryptedStream.Writable.write (_stream_writable.js:180:11)
      at write (_stream_readable.js:573:24)
      at flow (_stream_readable.js:582:7)
      at Socket.pipeOnReadable (_stream_readable.js:614:5)
      at Socket.EventEmitter.emit (events.js:92:17)
      at emitReadable_ (_stream_readable.js:408:10)
      at emitReadable (_stream_readable.js:404:5)
      at readableAddChunk (_stream_readable.js:165:9)
      at Socket.Readable.push (_stream_readable.js:127:10)
      at TCP.onread (net.js:511:21)

  6) WebSocket ssl can send and receive text data:
     TypeError: Uncaught, unspecified "error" event.
      at TypeError (<anonymous>)
      at WebSocket.EventEmitter.emit (events.js:74:15)
      at Receiver.self._receiver.onerror (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:566:10)
      at Receiver.error (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:301:8)
      at Receiver.processPacket (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:187:10)
      at Receiver.add (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:93:24)
      at CleartextStream.firstHandler (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:524:22)
      at CleartextStream.EventEmitter.emit (events.js:95:17)
      at CleartextStream.<anonymous> (_stream_readable.js:736:14)
      at CleartextStream.EventEmitter.emit (events.js:92:17)
      at emitReadable_ (_stream_readable.js:408:10)
      at emitReadable (_stream_readable.js:404:5)
      at readableAddChunk (_stream_readable.js:165:9)
      at CleartextStream.Readable.push (_stream_readable.js:127:10)
      at CleartextStream.read [as _read] (tls.js:510:10)
      at CleartextStream.Readable.read (_stream_readable.js:320:10)
      at EncryptedStream.write [as _write] (tls.js:366:25)
      at doWrite (_stream_writable.js:219:10)
      at writeOrBuffer (_stream_writable.js:209:5)
      at EncryptedStream.Writable.write (_stream_writable.js:180:11)
      at write (_stream_readable.js:573:24)
      at flow (_stream_readable.js:582:7)
      at Socket.pipeOnReadable (_stream_readable.js:614:5)
      at Socket.EventEmitter.emit (events.js:92:17)
      at emitReadable_ (_stream_readable.js:408:10)
      at emitReadable (_stream_readable.js:404:5)
      at readableAddChunk (_stream_readable.js:165:9)
      at Socket.Readable.push (_stream_readable.js:127:10)
      at TCP.onread (net.js:511:21)

  7) WebSocket ssl can send and receive very long binary data:
     TypeError: Uncaught, unspecified "error" event.
      at TypeError (<anonymous>)
      at WebSocket.EventEmitter.emit (events.js:74:15)
      at Receiver.self._receiver.onerror (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:566:10)
      at Receiver.error (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:301:8)
      at Receiver.processPacket (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:187:10)
      at Receiver.add (/Users/ahudgins/bug/node_modules/ws/lib/Receiver.js:93:24)
      at CleartextStream.firstHandler (/Users/ahudgins/bug/node_modules/ws/lib/WebSocket.js:524:22)
      at CleartextStream.EventEmitter.emit (events.js:95:17)
      at CleartextStream.<anonymous> (_stream_readable.js:736:14)
      at CleartextStream.EventEmitter.emit (events.js:92:17)
      at emitReadable_ (_stream_readable.js:408:10)
      at emitReadable (_stream_readable.js:404:5)
      at readableAddChunk (_stream_readable.js:165:9)
      at CleartextStream.Readable.push (_stream_readable.js:127:10)
      at CleartextStream.read [as _read] (tls.js:510:10)
      at CleartextStream.Readable.read (_stream_readable.js:320:10)
      at EncryptedStream.write [as _write] (tls.js:366:25)
      at doWrite (_stream_writable.js:219:10)
      at writeOrBuffer (_stream_writable.js:209:5)
      at EncryptedStream.Writable.write (_stream_writable.js:180:11)
      at write (_stream_readable.js:573:24)
      at flow (_stream_readable.js:582:7)
      at Socket.pipeOnReadable (_stream_readable.js:614:5)
      at Socket.EventEmitter.emit (events.js:92:17)
      at emitReadable_ (_stream_readable.js:408:10)
      at emitReadable (_stream_readable.js:404:5)
      at readableAddChunk (_stream_readable.js:165:9)
      at Socket.Readable.push (_stream_readable.js:127:10)
      at TCP.onread (net.js:511:21)

  8) WebSocketServer #ctor starts a server on a given port:
     Error: listen EADDRINUSE
      at errnoException (net.js:884:11)
      at Server._listen2 (net.js:1022:14)
      at listen (net.js:1044:10)
      at net.js:1118:9
      at dns.js:72:18
      at process._tickCallback (node.js:415:13)

  9) WebSocketServer #close cleans up websocket data on a precreated server:
     Error: listen EADDRINUSE
      at errnoException (net.js:884:11)
      at Server._listen2 (net.js:1022:14)
      at listen (net.js:1044:10)
      at Server.listen (net.js:1110:5)
      at Context.<anonymous> (/Users/ahudgins/bug/node_modules/ws/test/WebSocketServer.test.js:198:11)
      at Test.Runnable.run (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runnable.js:196:15)
      at Runner.runTest (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runner.js:351:10)
      at /Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runner.js:397:12
      at next (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runner.js:277:14)
      at /Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runner.js:286:7
      at next (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runner.js:234:23)
      at Object._onImmediate (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runner.js:254:5)
      at processImmediate [as _immediateCallback] (timers.js:330:15)

  10) WebSocketServer #clients returns a list of connected clients:
     Error: listen EADDRINUSE
      at errnoException (net.js:884:11)
      at Server._listen2 (net.js:1022:14)
      at listen (net.js:1044:10)
      at net.js:1118:9
      at dns.js:72:18
      at process._tickCallback (node.js:415:13)

  11) WebSocketServer #handleUpgrade can be used for a pre-existing server:
     Error: timeout of 2000ms exceeded
      at null._onTimeout (/Users/ahudgins/bug/node_modules/ws/node_modules/mocha/lib/runnable.js:167:14)
      at Timer.listOnTimeout [as ontimeout] (timers.js:110:15)


make[1]: *** [run-tests] Error 11
make: *** [test] Error 2
npm ERR! weird error 2
npm ERR! not ok code 0

[einaros]

I suggest upgrading to the newest version of node 0.10. There have been issues with a few of the earlier 0.10 versions, and I doubt anyone will want to spend time adapting ws to work with all of their quirks.

[3rd-Eden]

There's currently only one 1 test failing under node 0.10 and I have no idea how we can hack around that.