-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide on minimum supported rust version #267
Comments
CI broke again because async-global-executor moved to version 1.59.0. This is was created because the same thing happened with time. ProposalGiven how common the six months approach seems to be I think we should use the same, it's likely that consumers have had to update already because the six month MSRV policy is so common. |
Fix for async-global-executor #278 |
cc @KillingSpark @niklaskorz @morajabi @sax @stuqdog @KallDrexx @xnorpx @rainliu @morajabi @billylindeman I'd to go with my proposal above unless there's a strong argument against that |
Makes sense to me. Almost all my work ends up on the latest rust compiler. |
Implicit in my proposal is that changes to MSRV will not be considered breaking either, just making this explicit |
I made a PR that updates the minimum to 1.60.0 and documents the suggested proposal |
I've merged #337 so I'm closing this now. Policy is to have an MSRV for compilers released in the last six months and bump the minimum version as non breaking. |
Currently we support Rust 1.57.0 as our minimal version. However, this is entirely arbitrary. We should have a policy.
Some inspiration:
tokio
time
serde
See serde-rs/serde#2257
rcgen
Please add suggestions and inspirations from other crates(ideally those that are likely to be in a consumers tree already)
The text was updated successfully, but these errors were encountered: