Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets "Pywb Error" string as translatable in error template #868

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Quirinus
Copy link
Contributor

@Quirinus Quirinus commented Oct 26, 2023

Description

Sets the "Pywb Error" string in the <h2> heading as translatable in the error.html template.

Motivation and Context

Screenshots (if appropriate):

image
The "Pywb Error" isn't translated, but this pull request fixes that.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

I have no idea how to run the tests, but hopefully just making a string translatable shouldn't break anything.

Copy link
Contributor

@edsu edsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing and fixing this!

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@tw4l
Copy link
Member

tw4l commented Nov 23, 2023

Confirmed that the test failure seen in CI is happening on main and not related to this change (thought so but wanted to make sure!), so I'm going to go ahead and merge this in and resolve that separately.

@tw4l tw4l merged commit af92a97 into webrecorder:main Nov 23, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String not set as translatable in template
3 participants