Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit of redirect optimization: #753

Merged
merged 3 commits into from
Aug 20, 2022
Merged

Conversation

ikreymer
Copy link
Member

Description

if a revisit is of a redirect (3xx response) and revisit has http headers, return
the http headers with empty payload

Motivation and Context

A further optimization building on top of #751, don't bother loading the revisit original, if the response is 3xx and the payload will be ignored. Just serve the 3xx response with empty payload.

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

- if a revisit is of a redirect (3xx response) and revisit has http headers, return
the http headers with empty payload -- don't bother loading the original record
builds on changes in #751
@ikreymer ikreymer merged commit c121198 into main Aug 20, 2022
@ikreymer ikreymer deleted the redirect-revisit-empty-payload branch August 20, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant