Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log behavior-related messages if no behaviors are set #651

Closed
tw4l opened this issue Jul 24, 2024 · 1 comment · Fixed by #672
Closed

Don't log behavior-related messages if no behaviors are set #651

tw4l opened this issue Jul 24, 2024 · 1 comment · Fixed by #672
Assignees

Comments

@tw4l
Copy link
Member

tw4l commented Jul 24, 2024

Related to webrecorder/browsertrix#1963 (review)

When the behaviors argument is set to an empty list (meaning no behaviors), we should not log behavior-related messages such as "Running behaviors", "Run Script Started", and "Waiting for behaviors to finish" among others.

Their presence is confusing noise if behaviors are disabled.

@tw4l tw4l self-assigned this Jul 24, 2024
@tw4l tw4l moved this from Triage to Ready in Webrecorder Projects Jul 24, 2024
@ikreymer
Copy link
Member

Yeah, I think we should make sure we disable the execution of browsertrix-behaviors altogether if all behaviors are disabled, that may not be the case..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants