Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoEmitOnErrorsPlugin documentation #1135

Merged
merged 1 commit into from
Apr 23, 2017

Conversation

simon04
Copy link
Collaborator

@simon04 simon04 commented Apr 19, 2017

No description provided.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skipjack skipjack merged commit 50358c0 into webpack:master Apr 23, 2017
@skipjack
Copy link
Collaborator

@simon04 on the assumption that at some point we may implement something like #1017 (and also the convention helps with consistency/readability), I think @bebraw and I are both slowly shifting our commit messages over to the standard defined here.

I'm starting to use the squash and merge option to rewrite prs that don't follow the convention on merge, so if you could try that as well it would be helpful. You don't necessarily have to follow the convention on each branch but we should at least attempt to stick to it on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants