Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Passing a Configuration page #401

Closed
SpaceK33z opened this issue Nov 23, 2016 · 5 comments · Fixed by #898
Closed

Documentation: Passing a Configuration page #401

SpaceK33z opened this issue Nov 23, 2016 · 5 comments · Fixed by #898

Comments

@SpaceK33z
Copy link
Member

https://webpack.js.org/configuration/passing-a-config/

This page is not finished yet.

@simon04
Copy link
Collaborator

simon04 commented Feb 16, 2017

I'm struggling to associate the content of extended configuration definitions with "Passing a Configuration". What his "passed"? Alternative suggestion: "Configuration Types" (relating to Javascript types function, array, Promise).

See also my comment: #895 (comment)

@bebraw
Copy link
Contributor

bebraw commented Feb 16, 2017

Configuration types would be better, yeah. Better rename the page, add the env bits there and include multi-compiler mode (return an array) too. That covers it.

@simon04
Copy link
Collaborator

simon04 commented Feb 16, 2017

Documenting multi-compiler mode is covered in #898.

It's just that https://webpack.js.org/configuration/environment/#using-environment-variables does not fit into the new title. Maybe keep this section on a separate page titled "environment variables"? Or keep --env on both pages?

@bebraw
Copy link
Contributor

bebraw commented Feb 16, 2017

Using --env would fit the suggested page. Using environment variables could become a guide. It's out of place there.

@simon04
Copy link
Collaborator

simon04 commented Feb 16, 2017

Good idea. PR #898 is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants