Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGES: change disableHostCheck and allowedHosts to firewall option #2715

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

disableHostCheck and allowedHosts options should be merged into a single firewall option

Breaking Changes

  • disableHostCheck and allowedHosts removed in favor of firewall

Additional Info

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #2715 into v4 will decrease coverage by 0.04%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2715      +/-   ##
==========================================
- Coverage   92.89%   92.85%   -0.05%     
==========================================
  Files          37       37              
  Lines        1295     1301       +6     
  Branches      345      348       +3     
==========================================
+ Hits         1203     1208       +5     
- Misses         88       89       +1     
  Partials        4        4              
Impacted Files Coverage Δ
lib/utils/createConfig.js 94.44% <87.50%> (-1.15%) ⬇️
lib/Server.js 96.33% <100.00%> (ø)
lib/utils/normalizeOptions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45cdeb...3869c42. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @hiroppy

Good job!

@hiroppy
Copy link
Member

hiroppy commented Aug 25, 2020

Need to resolve conflicts.

@alexander-akait
Copy link
Member

/cc @Loonride

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when CI was green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants