Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): rename clientOptions to client #2655

Merged

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Renaming clientOptions to client

Breaking Changes

Yes, renaming of option, though clientOptions was introduced on the v4 branch so there is no problem

Additional Info

@codecov
Copy link

codecov bot commented Jun 20, 2020

Codecov Report

Merging #2655 into v4 will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2655      +/-   ##
==========================================
- Coverage   92.46%   92.41%   -0.05%     
==========================================
  Files          34       34              
  Lines        1300     1292       -8     
  Branches      365      357       -8     
==========================================
- Hits         1202     1194       -8     
  Misses         93       93              
  Partials        5        5              
Impacted Files Coverage Δ
lib/servers/SockJSServer.js 94.11% <ø> (ø)
lib/servers/WebsocketServer.js 94.11% <ø> (ø)
lib/Server.js 95.90% <100.00%> (ø)
lib/utils/addEntries.js 100.00% <100.00%> (ø)
lib/utils/createConfig.js 95.50% <100.00%> (ø)
lib/utils/normalizeOptions.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4761bf...593ade9. Read the comment docs.

@hiroppy
Copy link
Member

hiroppy commented Jun 22, 2020

windows CI fails.

@knagaitsev
Copy link
Collaborator Author

@hiroppy I think it's just test instability, nothing related to the actual changes. I'm going to work on test stability improvements soon

@alexander-akait
Copy link
Member

Let's merge and stability test in the future

@alexander-akait alexander-akait merged commit eb9c58d into webpack:v4 Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants