Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): do mock window.location.reload and assign #2635

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 3, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

Remove my comment by this fixing

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #2635 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2635   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          34       34           
  Lines        1321     1321           
  Branches      373      373           
=======================================
  Hits         1220     1220           
  Misses         96       96           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9cd8e1...fe2057d. Read the comment docs.

@hiroppy hiroppy merged commit 37b0a9d into v4 Jun 3, 2020
@hiroppy hiroppy deleted the feature/fix-tests branch June 3, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants