Fix prefer hot from cli #2617
Merged
Fix prefer hot from cli #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the `hot` value prefers from CLI over the configuration
alexander-akait
commented
May 19, 2020
| const hasHotOnly = typeof argv.hotOnly !== 'undefined'; | ||
|
|
||
| if (hasHot || hasHotOnly) { | ||
| options.hot = hasHotOnly ? 'only' : argv.hot; |
There was a problem hiding this comment.
argv-parser doesn't support multiple types for argument so for compatibility we have --hot and --hot-only, anyway we should deprecate our CLI in v4 in favor webpack server (webpack-cli), so we can do it safely
Codecov Report
@@ Coverage Diff @@
## v4 #2617 +/- ##
==========================================
+ Coverage 92.25% 92.26% +0.01%
==========================================
Files 34 34
Lines 1317 1319 +2
Branches 370 371 +1
==========================================
+ Hits 1215 1217 +2
Misses 97 97
Partials 5 5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Resolve TODO
Breaking Changes
Yes
Additional Info
No