Migrate server on infrastructure logger #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
May 18, 2020
| serverData.server = server; | ||
| } catch (err) { | ||
| if (err.name === 'ValidationError') { | ||
| log.error(colors.error(options.stats.colors, err.message)); | ||
| console.error(colors.error(options.stats.colors, err.message)); |
There was a problem hiding this comment.
let's use console
alexander-akait
commented
May 18, 2020
| let compiler; | ||
|
|
||
| try { | ||
| compiler = webpack(config); | ||
| } catch (err) { | ||
| if (err instanceof webpack.WebpackOptionsValidationError) { | ||
| log.error(colors.error(options.stats.colors, err.message)); | ||
| console.error(colors.error(options.stats.colors, err.message)); |
There was a problem hiding this comment.
let's use console
alexander-akait
commented
May 18, 2020
| @@ -189,7 +190,8 @@ class Server { | |||
| proxyOptions.context = correctedContext; | |||
| } | |||
|
|
|||
| proxyOptions.logLevel = proxyOptions.logLevel || 'warn'; | |||
| proxyOptions.logLevel = this.compiler.options.infrastructureLogging.level; | |||
| proxyOptions.logProvider = () => this.logger; | |||
There was a problem hiding this comment.
Improve logging for proxy
Codecov Report
@@ Coverage Diff @@
## v4 #2614 +/- ##
==========================================
- Coverage 92.36% 92.25% -0.12%
==========================================
Files 35 34 -1
Lines 1323 1317 -6
Branches 375 370 -5
==========================================
- Hits 1222 1215 -7
- Misses 96 97 +1
Partials 5 5
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
migrate-server-on-infrastructure-logger
branch
from
ed45604 to
d7b8529
Compare
|
Seem to be watchpack broken when you have |
alexander-akait
force-pushed
the
migrate-server-on-infrastructure-logger
branch
2 times, most recently
from
8f31674 to
51c76d3
Compare
BREAKING CHANGE: `log`, `logLevel`, `logTime`, `noInfo`, `quiet`, `reporter` and `warn` options were removed in favor built-in webpack logger, please use https://webpack.js.org/configuration/other-options/#infrastructurelogginglevel for enable and setup logging output
alexander-akait
force-pushed
the
migrate-server-on-infrastructure-logger
branch
from
51c76d3 to
f3d0431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No, existing tests
Motivation / Use-Case
Use built-in webpack logger for server and dev-middleware
Breaking Changes
Yes
Additional Info
No