Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add ws error logging #2594

Merged
merged 1 commit into from
May 12, 2020
Merged

Conversation

knagaitsev
Copy link
Collaborator

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

I missed a TODO where I meant to add error logging for ws and sockjs after fixing client dir structure

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #2594 into v4 will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v4    #2594      +/-   ##
==========================================
- Coverage   92.84%   92.52%   -0.32%     
==========================================
  Files          35       35              
  Lines        1313     1325      +12     
  Branches      368      370       +2     
==========================================
+ Hits         1219     1226       +7     
- Misses         89       94       +5     
  Partials        5        5              
Impacted Files Coverage Δ
client-src/clients/SockJSClient.js 63.63% <100.00%> (+3.63%) ⬆️
client-src/clients/WebsocketClient.js 55.81% <100.00%> (-1.69%) ⬇️
client-src/default/utils/log.js 91.17% <0.00%> (-8.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8775a07...7f97f79. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving TODO

@hiroppy hiroppy changed the title Add ws error logging feat(client): add ws error logging May 12, 2020
@hiroppy hiroppy merged commit e826119 into webpack:v4 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants