fix: remove lazy and filename options #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/upgrade-deps #2544 +/- ##
========================================================
- Coverage 93.40% 93.36% -0.04%
========================================================
Files 34 34
Lines 1335 1327 -8
Branches 381 375 -6
========================================================
- Hits 1247 1239 -8
Misses 85 85
Partials 3 3
Continue to review full report at Codecov.
|
2 tasks
alexander-akait
approved these changes
Apr 28, 2020
|
/cc @Loonride |
hiroppy
force-pushed
the
feature/remove-lazy-and-filename
branch
from
51cc950 to
085813e
Compare
|
Resolved conflicts. |
|
@hiroppy let's ignore unstable tests and focus on fixing them before v4 stable release |
alexander-akait
pushed a commit
that referenced
this pull request
Apr 29, 2020
* chore(deps): upgrade deps * style: run prettier * test: update * ci: remove Node@8 * test(cli): add windows support * chore(deps): downgrade puppeteer * chore(deps): downgrade some deps * fix(hot): enable hot option as default (#2546) BREAKING CHANGE: the `hot` option is `true` by default, the `hotOnly` option was removed in favor `{ hot: 'only' }` * fix: remove lazy and filename options (#2544) BREAKING CHANGE: `lazy` and `filename` options was removed
alexander-akait
pushed a commit
that referenced
this pull request
May 8, 2020
* chore(deps): upgrade deps * style: run prettier * test: update * ci: remove Node@8 * test(cli): add windows support * chore(deps): downgrade puppeteer * chore(deps): downgrade some deps * fix(hot): enable hot option as default (#2546) BREAKING CHANGE: the `hot` option is `true` by default, the `hotOnly` option was removed in favor `{ hot: 'only' }` * fix: remove lazy and filename options (#2544) BREAKING CHANGE: `lazy` and `filename` options was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
Delete these options because webpack-dev-middleware won't support them.
Breaking Changes
yes
Additional Info