Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add client code for node-webkit target #1942

Merged
merged 1 commit into from
May 31, 2019

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Regression

Breaking Changes

No

Additional Info

https://github.com/peter23/NW.js-svelte-boilerplate

@alexander-akait alexander-akait requested a review from hiroppy as a code owner May 31, 2019 16:07
@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #1942 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1942      +/-   ##
=========================================
+ Coverage   91.49%   91.5%   +0.01%     
=========================================
  Files          18      18              
  Lines         835     836       +1     
  Branches      262     263       +1     
=========================================
+ Hits          764     765       +1     
  Misses         68      68              
  Partials        3       3
Impacted Files Coverage Δ
lib/utils/addEntries.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd218ef...3908ff8. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants