-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onListening
option
#1930
feat: onListening
option
#1930
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
+ Coverage 88% 88.03% +0.02%
==========================================
Files 16 16
Lines 817 819 +2
Branches 260 261 +1
==========================================
+ Hits 719 721 +2
Misses 84 84
Partials 14 14
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1930 +/- ##
==========================================
+ Coverage 91.11% 91.13% +0.02%
==========================================
Files 18 18
Lines 833 835 +2
Branches 261 262 +1
==========================================
+ Hits 759 761 +2
Misses 70 70
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add tests to options.test.js. https://github.com/webpack/webpack-dev-server/blob/master/test/options.test.js
9994522
to
f831e3f
Compare
f831e3f
to
9a08550
Compare
/cc @hiroppy done |
Thanks |
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
fixes #1569
Breaking Changes
No
Additional Info