fix(regression): always get necessary stats for hmr #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
fix-regression-always-get-necessary-stats-for-hmr
branch
from
0b4dd62 to
8573b21
Compare
alexander-akait
force-pushed
the
fix-regression-always-get-necessary-stats-for-hmr
branch
from
8573b21 to
6c939ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #1780 +/- ##
==========================================
+ Coverage 87.62% 87.68% +0.06%
==========================================
Files 9 9
Lines 590 593 +3
Branches 176 177 +1
==========================================
+ Hits 517 520 +3
Misses 61 61
Partials 12 12
Continue to review full report at Codecov.
|
|
Does that mean that we only respect |
|
@yoannmoinet yep, unfortunately we don't have tests and it is invalid solution, if something need respect too feel free to open a issue or do a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
fixes #1776
Breaking Changes
No because previously behavior was wrong
Additional Info
No