fix(bin): handle process signals correctly when the server isn't ready yet
#1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-ciniawsky
changed the title
SIGINT handling to work even if the server is not yet ready
alexander-akait
approved these changes
Aug 22, 2018
michael-ciniawsky
added
status: approved
and removed
pr: review
priority: 3 (important)
severity: 4 (inconvenient)
status: pending
labels
michael-ciniawsky
changed the title
SIGINT handling to work even if the server is not yet readySIGINT even if the server is not ready yet
edi9999
force-pushed
the
fix-sigint-handling
branch
from
debb5ce to
b724899
Compare
|
I have just pushed a fix that fixes the eslint issues. Hope this is going to be merged soon ! |
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
=======================================
Coverage 78.94% 78.94%
=======================================
Files 5 5
Lines 494 494
Branches 161 161
=======================================
Hits 390 390
Misses 104 104Continue to review full report at Codecov.
|
michael-ciniawsky
changed the title
SIGINT even if the server is not ready yetprocess signals correctly if the server is not ready yet
michael-ciniawsky
changed the title
process signals correctly if the server is not ready yetprocess signals correctly when the server isn't ready yet
|
Released in |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Issues
SemVer