From 4c6103ba9495a29c6e142373c8dad084a20b6bc8 Mon Sep 17 00:00:00 2001 From: Nitin Kumar Date: Wed, 13 Oct 2021 06:36:36 +0530 Subject: [PATCH] fix: typo in SSL information log (#3939) * fix: typo in SSL information log * test: update snapshots --- lib/Server.js | 4 ++-- .../__snapshots__/bonjour-option.test.js.snap.webpack4 | 3 ++- .../__snapshots__/bonjour-option.test.js.snap.webpack5 | 3 ++- .../cli/__snapshots__/http2-option.test.js.snap.webpack4 | 3 ++- .../cli/__snapshots__/http2-option.test.js.snap.webpack5 | 3 ++- .../cli/__snapshots__/https-option.test.js.snap.webpack4 | 9 ++++++--- .../cli/__snapshots__/https-option.test.js.snap.webpack5 | 9 ++++++--- 7 files changed, 22 insertions(+), 12 deletions(-) diff --git a/lib/Server.js b/lib/Server.js index 2046a05463..4a0af3b3f1 100644 --- a/lib/Server.js +++ b/lib/Server.js @@ -589,7 +589,7 @@ class Server { const del = require("del"); this.logger.info( - "SSL Certificate is more than 30 days old. Removing..." + "SSL certificate is more than 30 days old. Removing..." ); await del([certificatePath], { force: true }); @@ -599,7 +599,7 @@ class Server { } if (!certificateExists) { - this.logger.info("Generating SSL Certificate..."); + this.logger.info("Generating SSL certificate..."); const selfsigned = require("selfsigned"); const attributes = [{ name: "commonName", value: "localhost" }]; diff --git a/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack4 b/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack4 index bb6c172a07..88637ca79b 100644 --- a/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack4 +++ b/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack4 @@ -1,7 +1,8 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`"bonjour" CLI option should work using "--bonjour and --https" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ diff --git a/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack5 b/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack5 index bb6c172a07..88637ca79b 100644 --- a/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack5 +++ b/test/cli/__snapshots__/bonjour-option.test.js.snap.webpack5 @@ -1,7 +1,8 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`"bonjour" CLI option should work using "--bonjour and --https" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ diff --git a/test/cli/__snapshots__/http2-option.test.js.snap.webpack4 b/test/cli/__snapshots__/http2-option.test.js.snap.webpack4 index 7d9985a08f..c044c3f33c 100644 --- a/test/cli/__snapshots__/http2-option.test.js.snap.webpack4 +++ b/test/cli/__snapshots__/http2-option.test.js.snap.webpack4 @@ -1,7 +1,8 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`"http2" CLI option should work using "--http2" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ diff --git a/test/cli/__snapshots__/http2-option.test.js.snap.webpack5 b/test/cli/__snapshots__/http2-option.test.js.snap.webpack5 index 7d9985a08f..c044c3f33c 100644 --- a/test/cli/__snapshots__/http2-option.test.js.snap.webpack5 +++ b/test/cli/__snapshots__/http2-option.test.js.snap.webpack5 @@ -1,7 +1,8 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`"http2" CLI option should work using "--http2" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ diff --git a/test/cli/__snapshots__/https-option.test.js.snap.webpack4 b/test/cli/__snapshots__/https-option.test.js.snap.webpack4 index db0af10f59..c00c673304 100644 --- a/test/cli/__snapshots__/https-option.test.js.snap.webpack4 +++ b/test/cli/__snapshots__/https-option.test.js.snap.webpack4 @@ -10,7 +10,8 @@ exports[`"https" CLI option should warn using "--https-cacert" and "--https-ca" `; exports[`"https" CLI option should work using "--https" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ @@ -51,7 +52,8 @@ exports[`"https" CLI option should work using "--https-key-reset --https-key [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ @@ -68,7 +70,8 @@ exports[`"https" CLI option should work using "--no-https" 1`] = ` `; exports[`"https" CLI option should work using "--no-https-request-cert" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ diff --git a/test/cli/__snapshots__/https-option.test.js.snap.webpack5 b/test/cli/__snapshots__/https-option.test.js.snap.webpack5 index db0af10f59..c00c673304 100644 --- a/test/cli/__snapshots__/https-option.test.js.snap.webpack5 +++ b/test/cli/__snapshots__/https-option.test.js.snap.webpack5 @@ -10,7 +10,8 @@ exports[`"https" CLI option should warn using "--https-cacert" and "--https-ca" `; exports[`"https" CLI option should work using "--https" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ @@ -51,7 +52,8 @@ exports[`"https" CLI option should work using "--https-key-reset --https-key [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/ @@ -68,7 +70,8 @@ exports[`"https" CLI option should work using "--no-https" 1`] = ` `; exports[`"https" CLI option should work using "--no-https-request-cert" 1`] = ` -" [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem +" [webpack-dev-server] Generating SSL certificate... + [webpack-dev-server] SSL certificate: /node_modules/.cache/webpack-dev-server/server.pem [webpack-dev-server] Project is running at: [webpack-dev-server] Loopback: https://localhost:/ [webpack-dev-server] On Your Network (IPv4): https://:/