Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Migrate should move ModuleConcatenationPlugin to optimizations.concatenateModules #396

Closed
ematipico opened this issue Apr 10, 2018 · 1 comment
Closed

[Feature] Migrate should move ModuleConcatenationPlugin to optimizations.concatenateModules #396

ematipico opened this issue Apr 10, 2018 · 1 comment
Assignees
@bitpshr
Labels
Feature Help Wanted Migrate

Comments

@ematipico
Copy link
Contributor

Do you want to request a feature or report a bug?
Feature.

What is the current behavior?
At the moment migrate does nothing when it encounters ModuleConcatenationPlugin

What is the expected behavior?
It should migrate to optimizations.concatenateModules

If this is a feature request, what is motivation or use case for changing the behavior?
ModuleConcatenationPlugin is now changes in webpack v4 and migrate, as its objective, should add a flag inside the optimizations object
@ematipico ematipico added this to the Vatican (v3) milestone Apr 10, 2018
@bitpshr
Copy link
Member

bitpshr commented Apr 10, 2018

I can take this since I've been working on the migrate code for #390.

@bitpshr bitpshr mentioned this issue Apr 11, 2018
Closed
@matheus1lva matheus1lva mentioned this issue Apr 12, 2018
Merged
@bitpshr bitpshr mentioned this issue Apr 14, 2018
Merged
@ematipico ematipico mentioned this issue Jul 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitpshr bitpshr

Labels
Feature Help Wanted Migrate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitpshr @ematipico