feat: allow to run commands not requiring webpack without webpack installation #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2907 +/- ##
==========================================
+ Coverage 94.85% 95.11% +0.25%
==========================================
Files 31 31
Lines 1673 1679 +6
Branches 468 480 +12
==========================================
+ Hits 1587 1597 +10
+ Misses 86 82 -4
Continue to review full report at Codecov.
|
alexander-akait
force-pushed
the
feat-allow-to-run-commands-without-webpack-instalaltion
branch
from
2186874
to
41868ba
Compare
alexander-akait
commented
Aug 24, 2021
| @@ -1,27 +1,27 @@ | |||
| import { devServerOptionsType } from "./types"; | |||
|
|
|||
| const WEBPACK_PACKAGE = process.env.WEBPACK_PACKAGE || "webpack"; | |||
| const WEBPACK_DEV_SERVER_PACKAGE = process.env.WEBPACK_DEV_SERVER_PACKAGE || "webpack-dev-server"; | |||
There was a problem hiding this comment.
@snitin315 We should document WEBPACK_DEV_SERVER_PACKAGE after merge this
alexander-akait
deleted the
feat-allow-to-run-commands-without-webpack-instalaltion
branch
|
Any plans on releasing this change in the near future? |
|
Yes, in near future, need to fix the one problem on webpack side |
anshumanv
pushed a commit
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Yes, some tests
If relevant, did you update the documentation?
No need
Summary
Allow to run
npx webpack-cli infowithoutwebpackinstallationDoes this PR introduce a breaking change?
No
Other information
due
v8-compile-cachehas bug withimport(), after this refactor webpack can useimport()to load ECMA modules, it is great fix