Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use logger to throw error with proper exit code #2076

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix: use logger to throw error with proper exit code #2076

merged 1 commit into from
Nov 10, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Nov 9, 2020 •
edited
Loading

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
Nope
Summary
user logger for error

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner November 9, 2020 02:05
@snitin315 snitin315 changed the title fix(webpack-cli): use logger for error with proper exit code fix: use logger to throw error with proper exit code Nov 9, 2020
@codecov
Copy link

codecov bot commented Nov 9, 2020 •
edited
Loading

Codecov Report

Merging #2076 (385f978) into master (cd09f85) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2076      +/-   ##
==========================================
- Coverage   68.54%   68.50%   -0.05%     
==========================================
  Files          76       76              
  Lines        2410     2413       +3     
  Branches      495      495              
==========================================
+ Hits         1652     1653       +1     
- Misses        758      760       +2
Impacted Files Coverage Δ
packages/webpack-cli/lib/utils/resolve-command.js 71.42% <0.00%> (-3.58%) ⬇️
packages/webpack-cli/lib/utils/run-command.js 37.50% <33.33%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd09f85...385f978. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes Nov 9, 2020
View reviewed changes
@snitin315
Copy link
Member Author

/cc @webpack/cli-team

alexander-akait
alexander-akait approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@snitin315
Copy link
Member Author

/cc @webpack/cli-team

anshumanv
anshumanv approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@snitin315 snitin315 merged commit 2c9069f into master Nov 10, 2020
@snitin315 snitin315 deleted the fix/error branch November 10, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshumanv anshumanv anshumanv approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snitin315 @alexander-akait @anshumanv @webpack-bot