fix: log error if --config-name is used without multiple configs #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
fix/config-name
branch
from
00f99ab
to
5c38fab
Compare
| } else { | ||
| newOptionsObject['options'] = namedOptions; | ||
| logger.warn('Multiple configurations not found. Please use "--config-name" with multiple configurations.'); | ||
| newOptionsObject['options'] = configOptions; |
There was a problem hiding this comment.
So that build is not interrupted and stats are printed.
There was a problem hiding this comment.
Or we can throw error and exit process too.
There was a problem hiding this comment.
I think it should be error and we should exit, because we can't found config
There was a problem hiding this comment.
Yep not exiting will set wrong expectations
snitin315
force-pushed
the
fix/config-name
branch
from
5c38fab
to
14f5740
Compare
snitin315
changed the title
alexander-akait
approved these changes
Oct 6, 2020
anshumanv
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
log warning if --config-name is used without multiple configs
Does this PR introduce a breaking change?
No
Other information
No