-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Chokidar to v3 for [email protected] #137
Comments
We can't do it because it is breaking change, what is broken? Can you create reproducible test repo? |
Would that directly cause a breaking change in the watchpack API? I don't see the need for a breaking change in watchpack to update a dependency. Or do I see this wrong? |
@guidobouman webpack@4 support node@6, |
Hmm... You mean Node 6, which has been EOL since april 30, 2019? I get that you want to respect old versions, even if they are EOL. But should a widespread package like webpack not also push ahead the platform as a whole? Google is decommissioning Node 6 cloud functions on April 22, 2020. And Amazon has deprecated Node 6 for Lambda functions on August 12, 2019: |
@guidobouman yes, but it will be in webpack@5 (we don't use |
Fair point. Sorry for pushing beyond reasonable semver logic. |
[email protected]
causes[email protected]
+[email protected]
to be installed. Which breaks on Windows withnpm ci
installs.Using
[email protected]
in thev1.x
branch allows[email protected]
to be installed, which allows ci installs on Windows to succeed again. With every package update, I now have to manually roll back thefsevents
update. Yes, I've brought this up with the package owner, but he's also in a position where[email protected]
is unmaintainable. This package would benefit a lot from the update in the currentv1.x
branch. Because current installs of webpack / watchpack are starting to fail more & more.The text was updated successfully, but these errors were encountered: