Backport preserve-symlinks fix to [email protected] for webpack@1

[vjpr]

@sokra Could we get a backport to enhanced-resolve@~0.9?

create-react-app depends on [email protected] which depends on enhanced-resolve@~0.9 and when installing with pnpm to a global symlinked store (the fastest way to install deps currently and what yarn may support eventually), it does not work.

[wclr]

I believe this is the solution:
https://webpack.js.org/configuration/resolve/#resolve-symlinks

[qiyuan-wang]

@whitecolor this solution won't work because it only deals with the first-level symlink.

When requiring a symlink package in inside a symlink package (like npminstall does, it installs all level dependencies in the form of symlink), it would throw a error of 'Module not found'.

I have a simple workaround for it: adding the root path to the config's resolve.modules. It works but slow down the building process.

We need a better way to solve this problem.

[wclr]

We need a better way to solve this problem.

Not using symlinks? 😄

[zkochan]

pnpm does not use the --preserve-symlinks flag anymore, so if webpack uses the same resolution algorithm that Node uses (which is resolving symlinks to real path), then it should work fine with pnpm.

I believe this is the solution:
https://webpack.js.org/configuration/resolve/#resolve-symlinks

Maybe this could help with the issue described here?

[zkochan]

I just checked today and the latest pnpm works fine with the latest CRA. @vjpr could you recheck and confirm. In that case, I believe this can be closed

[vjpr]

Yeh this issue was only webpack@1 related.