Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About min node version support #248

Closed
fwh1990 opened this issue May 11, 2020 · 25 comments · Fixed by #294
Closed

About min node version support #248

fwh1990 opened this issue May 11, 2020 · 25 comments · Fixed by #294

Comments

@fwh1990
Copy link

fwh1990 commented May 11, 2020

[email protected]: The engine "node" is incompatible with this module. Expected version ">=10.17".

It happened since you update dep cacache to version 15.0.3, because move-file is a dependency of cacache

@fwh1990
Copy link
Author

fwh1990 commented May 11, 2020

The changelog say the min node version is 10.13.0,so I guess this is a bug

@alexander-akait
Copy link
Member

alexander-akait commented May 12, 2020

Yep, unfortunately this is a transitive dependency and we can't fix it, package works on 10.13, just with a warning about experimental feature - fs.promises

@fwh1990
Copy link
Author

fwh1990 commented May 12, 2020

npm/cacache#37

@fwh1990
Copy link
Author

fwh1990 commented May 14, 2020

It's considered as an error and new deps can't be installed. I have to downgrade to 2.3.6

@alexander-akait
Copy link
Member

@fwh1990 just update node@10 to latest version, it is always recommended to use latest version

@ccambournac
Copy link

@fwh1990 just update node@10 to latest version, it is always recommended to use latest version

Not so easy on our CI servers...

@alexander-akait
Copy link
Member

alexander-akait commented May 15, 2020

Guys from npm teams always were very slow and often ignore problems

@ccambournac
Copy link

Guys from npm teams always were very slow and often ignore problems

Hi @evilebottnawi, what do you mean?

@alexander-akait
Copy link
Member

@ccambournac cacache develop by npm team

@ccambournac
Copy link

@evilebottnawi
It seems like using yarn resolutions to force the use of [email protected] allows latest terser-webpack-plugin to work with Node.js 10.16.2.

@alexander-akait
Copy link
Member

@ccambournac I think it is time say npm team in twittier something...

@ccambournac
Copy link

twittier something

Should I laugh? :)

@alexander-akait
Copy link
Member

@ccambournac Yep 😄

@ccambournac
Copy link

Sorry, I did not understand! 😄

@alexander-akait
Copy link
Member

@ccambournac I meant that post via twitter to npm command will probably move this point from a dead spot

@ccambournac
Copy link

@evilebottnawi I don't really feel like twitting to npm team... :)

@fwh1990
Copy link
Author

fwh1990 commented Jun 3, 2020

@evilebottnawi
It seems [email protected] have fixed this problem by this commit: npm/cacache@bf88af0

@alexander-akait
Copy link
Member

Will patch do release tomorrow

@ccambournac
Copy link

@evilebottnawi Everything now works as expected with the new release, thank you!

@fwh1990
Copy link
Author

fwh1990 commented Jun 8, 2020

Sorry, I have not handle this issue for a few days, maybe jest-worker is facing the same problem:

[email protected]: The engine "node" is incompatible with this module. Expected version ">= 10.14.2". Got "10.13.0"

Shouldn't it be in devDependencies

@alexander-akait
Copy link
Member

Oh, we still have a problem for jest-worker

/cc @SimenB It is possible to reduce node >= 10.13.0 for jest-worker?

@SimenB
Copy link

SimenB commented Jun 8, 2020

Yeah, probably. We have that version as a minimum in Jest since it includes nodejs/node#23206. That doesn't matter for jest-worker though, as it doesn't use the vm APIs, it's just easiest to use the same engines version for all packages. Can make an exception for jest-worker tho 👍

Could you open up an issue?

@alexander-akait
Copy link
Member

alexander-akait commented Jun 8, 2020

@SimenB Big thanks! Let's open an issue. jest-worker is great project.

@alexander-akait
Copy link
Member

Done jestjs/jest#10142

@fwh1990
Copy link
Author

fwh1990 commented Jun 9, 2020

I suggest author append 10.13.0 to matrix.node-version in file .github/workflows/nodejs.yml, so that you can catch errors automatically before users upgrade it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants