Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for registering webpack build dependencies #517

Conversation

thecrypticace
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Allow plugins to register build dependencies to properly handle webpack 5 persistent cache invalidation.

Breaking Changes

None.

Additional Info

N/A

@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #517 (f9c94f0) into master (6de5ef8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   97.95%   97.97%   +0.01%     
==========================================
  Files           5        5              
  Lines         245      247       +2     
  Branches       81       82       +1     
==========================================
+ Hits          240      242       +2     
  Misses          5        5              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de5ef8...f9c94f0. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add test

@thecrypticace thecrypticace force-pushed the feature/build-dependencies branch from a8701cb to f9c94f0 Compare March 3, 2021 15:02
@thecrypticace
Copy link
Contributor Author

Okay I added a test for this

@alexander-akait alexander-akait merged commit 2738776 into webpack-contrib:master Mar 5, 2021
@alexander-akait
Copy link
Member

Thanks

This was referenced Mar 5, 2021
This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants