perf: add experimental support for importModule
#737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the child compiler with a lightweight execution of modules within the module graph of the original compilation
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
- Coverage 89.69% 89.27% -0.42%
==========================================
Files 6 6
Lines 776 802 +26
Branches 240 247 +7
==========================================
+ Hits 696 716 +20
- Misses 77 83 +6
Partials 3 3
Continue to review full report at Codecov.
|
|
@vyobukhov https://github.com/vyobukhov/mini-css-memory-issues builds within |
This was referenced Apr 14, 2021
use old publicPath logic add CI tests for experimentalUseImportModule disable auxiliaryAssets test with experimentalUseImportModule
sokra
force-pushed
the
feature/import-module
branch
from
ebf324d to
a974120
Compare
src/loader.js
Outdated
| ); | ||
| return; | ||
| } | ||
| console.log(publicPath); |
There was a problem hiding this comment.
I think we need avoid it 😄
|
🚀 |
alexander-akait
approved these changes
Apr 16, 2021
|
I will do release tomorrow 🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the child compiler with a
lightweight execution of modules within
the module graph of the original compilation
To try the new approach.
experimentalUseImportModule: trueinMiniCssPluginoptionspublicPathinMiniCssPluginoptions, that doesn't work yetoutput.publicPathin webpack optionsThis PR contains a:
Motivation / Use-Case
child compiler take up too much memory and performance
Breaking Changes
none
Additional Info
Not all tests are passing yet with the new approach.
There is nothing to do in mini-css-extract-plugin to fix this.
Currently I think that are all webpack problems that I will fix eventually.
Biggest problem currently is that it breaks with HMR.