fix: ignore attribute if mailto: is present
#145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
==========================================
+ Coverage 96.93% 96.96% +0.03%
==========================================
Files 2 2
Lines 98 99 +1
Branches 19 20 +1
==========================================
+ Hits 95 96 +1
Misses 3 3
Continue to review full report at Codecov.
|
alexander-akait
added
priority: 5 (nice to have)
semver: Patch
severity: 3 (broken)
type: Feature
type: Bug
and removed
type: Feature
labels
|
Added test |
alexander-akait
approved these changes
Sep 29, 2017
michael-ciniawsky
changed the title
mailto: is present
michael-ciniawsky
added
status: Approved
and removed
priority: 5 (nice to have)
severity: 3 (broken)
labels
This was referenced Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
If I have a 'mailto' inside a href in an anchor tag file-loader tries to load a non existent file called "mailto:[email protected]"
What is the new behavior?
Ignore href in anchor tag if the string 'mailto:' is present
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: