perf: enable cache by default #213
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 282 282
Branches 78 78
=========================================
Hits 282 282
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
src/options.js
Outdated
| @@ -47,6 +47,8 @@ const schema = require('./options.json'); | |||
| */ | |||
| function getOptions(pluginOptions) { | |||
| const options = { | |||
| cache: true, | |||
| cacheLocation: 'node_modules/.cache/.eslintcache', | |||
There was a problem hiding this comment.
Do you think it is make a sense to provide it by default, because eslint does the same
There was a problem hiding this comment.
The eslint places the file in the root of the project.
I think it would be more convenient to put it inside node_modules, so there's no need to add it to .gitignore
There was a problem hiding this comment.
let's use node_modules/.cache/eslint-webpack-plugin/.eslintcache, because we should always use vendor prefix to avoid overlapping with other tools
Resolve #210
This PR contains a:
Motivation / Use-Case
Enabling the cache by default the execution time decreases dastrically
Breaking Changes
No
Additional Info
The cache localtion is set to
node_modules/.cache/.eslintcacheso no need to add it in.gitignore