-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: lint modules that are cached with webpack's filesystem cache #197
Conversation
If webpack is setup with cache type `filesystem`, the `succeedModule` hook is not called for cached modules and no linting is run for them. Tap the `stillValidModule` hook to lint cached modules. Fixes webpack-contrib#130
|
/cc @ricardogobbosouza hello, can you review? |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #197 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 280 283 +3
Branches 78 78
=========================================
+ Hits 280 283 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is this gonna be reviewed/merged anytime soon? Really keen to see this in a release |
Sorry for the delay, my considerations:
|
@ricardogobbosouza Thank you! Re: performance, could we use ESLint's own |
This changes caused Hot Module Replacement build to be very slow after save files. |
This PR contains a:
Motivation / Use-Case
If webpack is setup with cache type
filesystem
, thesucceedModule
hook is not called for cached modules and no linting is run for them. Tap thestillValidModule
hook to lint cached modules.Note regarding testing, I tried several strategies but the only one that I managed to get working was to create two different compilers and have the second one pickup the cache left by the first one.
Fixes #130
Breaking Changes
Additional Info