-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Apollo Tracing #289
Comments
Hey, we discussed this feature couple times. Please check #200 and #94 for reference. In short, we discussed two ways how to do this at the library level:
But we've got type loading mechanism since then and I think we can do something else now: we can wrap type loader with our own closure which will, in turn, wrap all field resolvers of a type being loaded. So any schema using type loading can benefit from it. It will be still not ideal in terms of performance (still have to loop through all fields of all types loaded during a query), but it will be way more performant than full schema scan. PRs are welcome! I guess we can just write a simple function somewhere under GraphQL\Utils for such a wrapper. |
This feature is implemented in Lighthouse - see https://github.com/nuwave/lighthouse/tree/master/src/Tracing. |
It would be great to be able to leverage Apollo Engine for performance tracing (https://www.apollographql.com/docs/engine/performance.html). I believe in order to do that we would need to implement an apollo-tracing extension in PHP (https://github.com/apollographql/apollo-tracing).
The text was updated successfully, but these errors were encountered: