Order of input object values

[kinglozzer]

When InputObjectType values are parsed, they’re re-ordered to match the order they are set in the schema definition:

graphql-php/src/Utils/Value.php

Lines 124 to 126 in d6c965e

	$fields = $type->getFields();
	foreach ($fields as $fieldName => $field) {
	if (array_key_exists($fieldName, $value)) {

We (Silverstripe framework) pass sort order args as input objects, e.g:

Query:

query ($sort: SortFields) {
  readObjects(sort: $sort) {
    created,
    name
  }
}

Variables:

{
  "sort": {
    "created": "ASC",
    "name": "ASC"
  }
}

If name was defined first in the schema for SortFields, the objects returned will come back in the wrong order as that is what comes through “first” in the resulting query.

Is this something that could be changed in this library? Are we misunderstanding how this ordering works/should we be using a different approach to ensure the order of these sort fields is preserved?

Thanks!

[LastDragon-ru]

Is this something that could be changed in this library?

According to the spec

Input object fields may be provided in any syntactic order and maintain identical semantic mean

These two operations are semantically identical:

{
  nearestThing(location: { lon: 12.43, lat: -53.211 })
}

{
  nearestThing(location: { lat: -53.211, lon: 12.43 })
}

should we be using a different approach to ensure the order of these sort fields is preserved?

You can use array, but you probably will need to add some check to make sure that only one field passed (until @oneOf, #619). You can also check my package to see how we a doing it.

{
  "sort": [
    {"created": "ASC"},
    {"name": "ASC"}
  ]
}