Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isEmpty needs better static-analysis coverage #192

Open
zerkms opened this issue Apr 25, 2020 · 2 comments
Open

isEmpty needs better static-analysis coverage #192

zerkms opened this issue Apr 25, 2020 · 2 comments

Comments

@zerkms
Copy link
Contributor

zerkms commented Apr 25, 2020

Triggered by #191 initially, it should also check that string, array, int, and other types also narrowed correspodingly.
@zerkms zerkms mentioned this issue Apr 26, 2020
Closed
@Ocramius
Copy link
Contributor

IMO doesn't need specific testing on our end, but rather in vimeo/psalm upstream

@zerkms
Copy link
Contributor Author

zerkms commented Jan 19, 2021

I think it still needs here as well - it's a part of the public assert contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ocramius @zerkms