Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the clamp() algorithm #347

Closed
zolkis opened this issue Feb 15, 2023 · 2 comments
Closed

Add the clamp() algorithm #347

zolkis opened this issue Feb 15, 2023 · 2 comments

Comments

@zolkis
Copy link
Collaborator

zolkis commented Feb 15, 2023

This is to track the algorithm specification for the clamp() operation.
Depends on #336.

@zolkis
Copy link
Collaborator Author

zolkis commented Feb 15, 2023

What needs discussion:

  • This is one of those ops that may return an operator (nowadays MLActivation) or an MLOperand. Check if the steps are appropriately formulated.
  • Dependency on MLActivation constructor (with an MLOperand input, output and the op name).
  • Dependency on MLOperand internal slot (of type MLOperandDescriptor).

@inexorabletash
Copy link
Member

I believe this is complete. Marking closed, if anything is still outstanding please re-open or file a new issue with the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants