Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to use single words in enums if possible #267

Closed
kenchris opened this issue May 18, 2022 · 2 comments
Closed

Attempt to use single words in enums if possible #267

kenchris opened this issue May 18, 2022 · 2 comments

Comments

@kenchris
Copy link

enum MLPowerPreference {
  "default",
  "high-performance",
  "low-power"
};

Like the above could very well use "performance" and "efficiency" instead. Also, I think it is more common to use "auto" (up to the platform) that "default". "auto" also better reflects that it might change depending on system settings instead of "default" that sounds like a fixed value

@anssiko
Copy link
Member

anssiko commented May 18, 2022

Thanks for your comment. This topic is discussed in #169. Please migrate this comment to that issue as appropriate.

@anssiko
Copy link
Member

anssiko commented May 24, 2022

@kenchris thanks for migrating your comment to #169. I'll close this issue and we'll continue in there.

@anssiko anssiko closed this as completed May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants