Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a light-weight process to guide submitting new operator requests to WebNN #231

Closed
anssiko opened this issue Nov 18, 2021 · 2 comments
Labels

Comments

@anssiko
Copy link
Member

anssiko commented Nov 18, 2021

From WebML WG Teleconference – 18 Nov 2021:

RESOLUTION: Create a light-weight process to guide submitting new operator requests to WebNN

Recording this resolution as an issue so we remember to bootstrap this process.

In our discussions, the following ONNX guidelines were suggested to be adopted for WebNN:

  • "Prefer static attributes over dynamic input values"
  • "Shape inference logic should be included"

Concretely, we could implement this process as an issue/PR template.

Feel free to share best practices/guidelines here to be used as a basis for the first version.

@huningxin
Copy link
Contributor

As we are starting to work on WebNN v2 features, like transformers, more new op proposals are coming. There is a demand to clarify the process and criteria for adding new ops.

Also, in WebML WG Teleconference – 13 April 2023, @wchao1115 proposed that

Chai: I'd like us to write contribution guidelines for spec changes to help contributors.

Ideally, this issue could be fixed by the guidelines as the 4th category of contribution:

  1. New content, add new ops, here's why with likely uber issue defining the rationale, this category is the most time consuming for the editor, need to understand the direction and keep the API consistent with the charter

/cc @fdwr @wacky6

@anssiko
Copy link
Member Author

anssiko commented Apr 19, 2023

Fixed by #381 and specifically the section Proposing and adding a new operation.

@anssiko anssiko closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants