-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3 installation and usage: a few pointers #584
Comments
I apologize for that. Components aren't fully renderless, it renders Your example with super-tiny-icons is correct, but don't forget to make image accessible. <s-whats-app
:window-features="windowFeatures"
:share-options="shareOptions"
:use-native-behavior="useNativeBehavior"
@popup-close="onClose"
@popup-open="onOpen"
@popup-block="onBlock"
@popup-focus="onFocus"
>
<img
:src="stiWhatsApp"
width="24"
height="24"
aria-hidden="true"
alt=""
/>
</s-whats-app> |
Fixed in |
That ARIA is a good addition! Sidenote: This has nothing to do with vue-socials; choosing your image is mostly personal taste, I actually ended up with using Font-Awesome instead, because I wanted the icons with custom colors, which is not possible with super-tiny-icons, unless you edit the SVG or use JS SVG loaders. Just something to consider as well. |
I just installed and used this component in my Vue3/Quasar project. Here are the three things I struggeled with a little bit to get it to work. It's meant as a constructive critism. It may help future users. :-)
Don't install next, (2.0.0) but install latest (2.0.1), the import fix is a must-have.
I didn't know this thing was renderless, so took me a while to figure that out. I think renderless is better, and had almost selected a different component as I thought this one wasn't. I now realize that is what was meant by "Customizable"/"Unstyled". IMHO, you might want to clarify this somewhere.
The global component registration isn't necessary. Unless the buttons are used everywhere, it's probably better (because code splitting) to locally register them. Or not?? Right?
Quasar boot file for global registration:
Local registration:
Usage (SVG from the Storybook demo).
The super-tiny-icons package might be good companion to this plugin.
With Super-Tiny-Icons, add the import
import stiWhatsApp from 'super-tiny-icons/images/svg/whatsapp.svg'
Just my experience :-)
The text was updated successfully, but these errors were encountered: