Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetch::error test to _common.ts #85

Closed
molant opened this issue Apr 6, 2017 · 2 comments
Closed

Add fetch::error test to _common.ts #85

molant opened this issue Apr 6, 2017 · 2 comments
Labels
area:connector type:testing

Comments

@molant
Copy link
Member

molant commented Apr 6, 2017

We are not currently testing that fetch::error is properly emitted (and CDP doesn't emit it).
Need to fix this.
@molant molant self-assigned this Apr 6, 2017
@molant molant mentioned this issue Apr 10, 2017
Closed
@molant molant assigned sarvaje and unassigned molant Apr 27, 2017
@molant
Copy link
Member Author

molant commented Apr 27, 2017

This is done in #156

@sarvaje
Copy link
Contributor

sarvaje commented May 1, 2017

fix via c281939

@sarvaje sarvaje closed this as completed May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:connector type:testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@molant @sarvaje