-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using fixed-length arrays for some output arrays? #302
Comments
Do we know what the cost of a malloc is in emscripten? Something like |
I'm definitely not concerned with the performance cost for AdapterGetInfo, given it should be called basically once. It's more of an ergonomic improvement as you wouldn't need FreeMembers at all for this struct. It's feasible to do similar things for other structs as well, like changing |
Ah, that would be a problem only for C though and only in a few places so not super important either imho. |
Jul 18 meeting:
|
In Emscripten there were a few suggestions to use fixed-length arrays for some outputs to avoid needing FreeMembers. In particular AdapterInfo just has a few strings in it - we probably could get away with setting some fixed limit on their size, but
description
is the most unsure, since it might get wrapped repeatedly the way ANGLE does:ANGLE (Apple, ANGLE Metal Renderer: Apple M1 Pro, Version 14.5 (Build 23F79))
Discussion was here: emscripten-core/emscripten#22031 (comment)
The text was updated successfully, but these errors were encountered: