Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests that instantiate macros #240

Closed
kainino0x opened this issue Oct 21, 2023 · 2 comments
Closed

Add tests that instantiate macros #240

kainino0x opened this issue Oct 21, 2023 · 2 comments
Assignees
Labels
has resolution Issue is resolved, just needs to be done

Comments

@kainino0x
Copy link
Collaborator

With #158 we're going to have a nontrivial macro so we'll need to actually instantiate the macro to make sure it builds.

@kainino0x kainino0x self-assigned this Oct 21, 2023
@kainino0x kainino0x added the has resolution Issue is resolved, just needs to be done label Oct 21, 2023
@kainino0x
Copy link
Collaborator Author

I started writing some, and here's a fun tidbit: ULL, and even UINT64_MAX, don't officially work before C++11.

./main.inl:20:22: error: 'long long' is a C++11 extension [-Werror,-Wc++11-long-long]
        uint64_t z = UINT64_MAX;
                     ^

@kainino0x
Copy link
Collaborator Author

We have some tests; all the remaining work is part of #158, so I'm just going to consolidate this into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has resolution Issue is resolved, just needs to be done
Projects
None yet
Development

No branches or pull requests

1 participant