Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies should store relative path (not in node_modules) #242

Open
brollb opened this issue May 22, 2018 · 0 comments
Open

Dependencies should store relative path (not in node_modules) #242

brollb opened this issue May 22, 2018 · 0 comments
Labels
bug minor

Comments

@brollb
Copy link
Contributor

brollb commented May 22, 2018

Dependencies recorded in webgme-setup.json should record relative path (from the given project root) in path. In the config, it should use require.resolve to resolve the absolute path.

The current approach may have problems when nesting projects with shared dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brollb